-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support SpokePoolVerifier
contract for native and enabled routes
#861
feat: support SpokePoolVerifier
contract for native and enabled routes
#861
Conversation
ACX-1584 Deploy SpokePoolVerifiers via create2
This will prevent cases where native ETH is sent to an address that isn't a contract on a chain. In this case currently, the chain interprets the ETH send as a transfer to an EOA, so the user's ETH is lost. Deploying the SpokePoolVerifier to the same address for each chain ensures that a user's deposit of ETH is always sent to a chain's SpokePoolVerifier which then checks that the user issending to the intended spoke pool address This does require that the FE routes all native eth deposits to the spoke pool verifier as opposed to directly to the spoke pool |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/data/routes_1_0xc186fA914353c44b2E33eBE05f21846F1048bEda.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should reflect this addition to the Goerli route for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed here 33a177c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for reviewing my comments
This PR uses the
deposit
of aSpokePoolVerifier
contract if enabled via theroutes.json
config file and if the sending token is a native one.Closes ACX-1589
Needs across-protocol/scraper-api#266 before it can be merged.