-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Add gas costs to /gas-prices endpoint #1349
Closed
Closed
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6a524ac
improve(API): Add gas costs to /gas-prices endpoint
nicholaspai 3044ca9
Add gas costs to api
nicholaspai 6f2bcf3
Update gas-prices.ts
nicholaspai 051be80
Remove reading from cache
nicholaspai 7f4f2a8
Update gas-prices.ts
nicholaspai c4b202f
Update gas-prices.ts
nicholaspai dea6f94
Update gas-prices.ts
nicholaspai 67f7bb8
Allow caller to set token
nicholaspai ea9d923
Update gas-prices.ts
nicholaspai 1e0ec98
Update gas-prices.ts
nicholaspai 581a689
improve: Update SDK version to 3.3.30 to get access to more accurate …
nicholaspai 78a79d7
Merge branch 'sdk-3.3.30' into gas-costs
nicholaspai 97c0bf4
wip
nicholaspai 1589945
Merge branch 'sdk-3.3.30' into gas-costs
nicholaspai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should parallel how the /iimits endpoint computes the
gasFeePercent
today:gasPrice
computed usinggetMaxFeePerGas
and thegasUnits
passed from agetGasCosts()
call withomitMarkup = true
into getRelayerFeeDetails which ultimately calls the SDK'sgetGasCosts
function