Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct codeowner file syntax #1348

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

mrice32
Copy link
Contributor

@mrice32 mrice32 commented Dec 31, 2024

The syntax used in the codeowners file that was just committed differs slightly from the github canonical syntax.

  • They use a preceding / for root of the repo. Not sure if this is implicit if you drop it, but this is corrected to be safe.
  • api/* would only apply to files in the api directory, not to files in subdirectories. This is fixed by dropping the *.

Sorry for the confusion, I should have checked the syntax more carefully!

Feel free to merge once approved.

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 5:32am
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 5:32am

@nicholaspai nicholaspai merged commit e947b36 into master Dec 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants