support transfer with auth #1341
Open
+765
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dohaki
reviewed
Dec 31, 2024
api/relay/_utils.ts
Outdated
| depositData: DepositDataSchema, | ||
| validAfter: positiveIntStr(), | ||
| validBefore: positiveIntStr(), | ||
| nonce: hexString(), |
There was a problem hiding this comment.
Do we need to enforce a certain length here?
There was a problem hiding this comment.
yes probably a good idea! will add a modifier for this validator
scripts/tests/swap-auth.ts
Outdated
|
|
||
| type AuthPayload = Awaited<ReturnType<typeof buildAuthTxPayload>>; | ||
|
|
||
| async function swapWithPermit() { |
There was a problem hiding this comment.
Did you test a relay via auth already? Just out of curiosity
There was a problem hiding this comment.
Not yet, got rate limited by CG on first attempt. will address your comments and try again. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.