Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evm): N02 - Address typographical Errors in spoke pool #831

Open
wants to merge 5 commits into
base: svm-dev
Choose a base branch
from
+3 −3
Open

fix(evm): N02 - Address typographical Errors in spoke pool #831

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aaed6fa
WIP
chrismaree Jan 2, 2025
8b394ef
Merge branch 'svm-dev' into chrismaree/n02
chrismaree Jan 3, 2025
4f71cc3
Update contracts/SpokePool.sol
mrice32 Jan 6, 2025
e6e2a85
Merge branch 'svm-dev' into chrismaree/n02
chrismaree Jan 6, 2025
96a7d66
Merge branch 'chrismaree/n02' of github.com:across-protocol/contracts…
chrismaree Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contracts/SpokePool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ abstract contract SpokePool is
}

/**
* @notice An overloaded version of `unsafeDepositV3` that accepts `address` types for backward compatibility. *
* @notice An overloaded version of `unsafeDepositV3` that accepts `address` types for backward compatibility.
* @dev This version mirrors the original `unsafeDepositV3` function, but uses `address` types for `depositor`, `recipient`,
* `inputToken`, `outputToken`, and `exclusiveRelayer` for compatibility with contracts using the `address` type.
*
Expand Down Expand Up @@ -1294,7 +1294,7 @@ abstract contract SpokePool is
/**
* @notice Returns the deposit ID for an unsafe deposit. This function is used to compute the deposit ID
* in unsafeDepositV3 and is provided as a convenience.
* @dev msgSenderand depositor are both used as inputs to allow passthrough depositors to create unique
* @dev msgSender and depositor are both used as inputs to allow passthrough depositors to create unique
* deposit hash spaces for unique depositors.
* @param msgSender The caller of the transaction used as input to produce the deposit ID.
* @param depositor The depositor address used as input to produce the deposit ID.
Expand Down Expand Up @@ -1499,7 +1499,7 @@ abstract contract SpokePool is
bool success = _noRevertTransfer(l2TokenAddress, refundAddresses[i], refundAmounts[i]);

// If the transfer failed then track a deferred transfer for the relayer. Given this function would
// have revered if there was insufficient balance, this will only happen if the transfer call
// have reverted if there was insufficient balance, this will only happen if the transfer call
// reverts. This will only occur if the underlying transfer method on the l2Token reverts due to
// recipient blacklisting or other related modifications to the l2Token.transfer method.
if (!success) {
Expand Down
Loading