Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evm): L01 - Update function from public to external #827

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

chrismaree
Copy link
Member

@chrismaree chrismaree commented Jan 2, 2025

OZ identified that:

The claimRelayerRefund function of the SpokePool contract is declared as public but can be defined as external instead.

In order to improve overall code quality and to improve gas consumption, consider changing the function visibility to external.

This PR fixes this through the recommended update. In addition, this PR adds the associated interface to the V3SpokePoolInterface.sol file.

Signed-off-by: Chris Maree <[email protected]>
@chrismaree chrismaree changed the base branch from master to svm-dev January 2, 2025 10:36
@chrismaree chrismaree changed the title fix: L01 Update function from public to external fix: L01 - Update function from public to external Jan 2, 2025
@chrismaree chrismaree changed the title fix: L01 - Update function from public to external fix(evm): L01 - Update function from public to external Jan 7, 2025
@chrismaree chrismaree merged commit 38b0d9b into svm-dev Jan 9, 2025
9 checks passed
@chrismaree chrismaree deleted the chrismaree/l-01-public-vs-external branch January 9, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants