Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svm): shorten svm chain ids #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(svm): shorten svm chain ids #817

wants to merge 1 commit into from

Conversation

md0x
Copy link
Contributor

@md0x md0x commented Dec 20, 2024 •
edited
Loading

Changes proposed in this PR:

  • Shorten SVM chain ids to 6 bytes to prevent them from overflowing js Number type

getSolanaChainId("devnet") => 133268194659241
getSolanaChainId("mainnet")=> 34268394551451

@md0x
feat(svm): shorten svm chain ids
166c084 
Signed-off-by: Pablo Maldonado <[email protected]>
@md0x md0x marked this pull request as ready for review December 20, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismaree chrismaree Awaiting requested review from chrismaree chrismaree is a code owner

@Reinis-FRP Reinis-FRP Awaiting requested review from Reinis-FRP Reinis-FRP is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@md0x