Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert acquire-logger from a static library to an object library. #31

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

aliddell
Copy link
Member

Closes #28.

@aliddell aliddell linked an issue Dec 17, 2024 that may be closed by this pull request
@aliddell aliddell requested a review from nclack December 17, 2024 18:09
@tlambert03
Copy link
Collaborator

awesome!! This works for me.

For those building with meson, with this PR i can now easily build against acquire-zarr by just including this wrap in subprojects/acquire-zarr.wrap:

[wrap-git]
url = https://github.com/acquire-project/acquire-zarr
revision = 28-private-logger-library  # or later something else
depth = 1
method = cmake

and then adding aquire_zarr_dep = dependency('acquire-zarr') to my meson.build

thanks @aliddell

Copy link
Contributor

@jeskesen jeskesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would it make sense to add @tlambert03's comment about the wrapper to the README?

Copy link
Member

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aliddell aliddell merged commit bdcfbdd into main Dec 19, 2024
7 checks passed
@aliddell aliddell deleted the 28-private-logger-library branch December 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logger library should not be required by clients
4 participants