Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python tests (1) #11

Merged
merged 22 commits into from
Oct 14, 2024
Merged

Add Python tests (1) #11

merged 22 commits into from
Oct 14, 2024

Conversation

aliddell
Copy link
Member

  • Adds some basic tests for the settings classes
    • Adds Python tests to CI
  • Fixes binding of PyZarrStreamSettings::dimensions to allow list-like behavior in Python
  • Adds default values for previously uninitialized class members
  • Adds kwargs constructors and __repr__ to bound classes

aliddell and others added 21 commits October 8, 2024 17:36
@aliddell
bindings created
d6d47cf
@aliddell
pip install . working
e85d185
@aliddell
python -m build working (on Windows anyway)
2b648c1
@aliddell
get it building on linux
2ef675c
@aliddell
Remove test stub (save for the next PR)
9a44c42
@aliddell
Undo an overzealous rename
3978d55
@aliddell
Add Python wheel build job
2a4c0a8
@aliddell
Prepare for Python bindings
7ed144e
@aliddell
Merge branch 'python-bindings-prep' into python-bindings
68d3b0b
@aliddell
Don't export the enum values into the module base namespace.
c160d7c
@aliddell
(wip) some basic tests
7e51977
@aliddell
Revert CMake minimum version and use cmake_policy. Using builtin `BUI…
8c76e2d 
…LD_TESTING` cmake option.
@aliddell
Update build.yml
60a0bd5
@aliddell
Update release.yml
9c5c6bf
@aliddell
Merge branch 'python-bindings-prep' into python-bindings
1a9d1be
@aliddell
Merge remote-tracking branch 'upstream/python-bindings-prep' into pyt…
2dc2fa6 
…hon-bindings
@aliddell
Merge branch 'python-bindings' into python-tests
f3b1e84
@aliddell
Merge remote-tracking branch 'upstream/main' into python-bindings
40b14ad
@aliddell
Merge remote-tracking branch 'upstream/python-bindings' into python-t…
50f889d 
…ests
@aliddell
some simple tests
8faabe5
@aliddell
add python tests to CI
7e97dd7
@aliddell aliddell requested a review from jeskesen October 10, 2024 15:43
@aliddell aliddell changed the base branch from python-bindings to main October 10, 2024 15:43
@aliddell aliddell changed the base branch from main to python-bindings October 10, 2024 16:15
Base automatically changed from python-bindings to main October 10, 2024 18:55
jeskesen
jeskesen approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@jeskesen jeskesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aliddell aliddell merged commit 7d6dd61 into main Oct 14, 2024
16 checks passed
@aliddell aliddell deleted the python-tests branch October 14, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeskesen jeskesen jeskesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliddell @jeskesen