-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Python bindings #10
Conversation
…LD_TESTING` cmake option.
LGTM, but I'd like to get someone else's opinion on the Python packaging, because I don't know that part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, from my perspective, it wasn't readily understandable how to build the new python bindings. I did it the "CMake way", with a configure/build/install step, and they weren't installed in the "install" directory (as it appears there's no install step added in the
Over Slack, @aliddell showed me how to build it the "python" way: python -m build
, and that worked fine. So, I'll approve this, but can we open a new ticket to update build instructions?
.value("V3", ZarrVersion_3) | ||
.export_values(); | ||
|
||
py::enum_<ZarrDataType>(m, "DType") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A topic for discussion: do we think it might be worth building ways to implicitly (or explicitly) convert between numpy's DType & ZarrDataTypes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that might be worthwhile to do.
Tests coming later. Stay tuned...