Expose software trigger to snap frames #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review now. The problem with the flakiness of the test was that doing p.video[0].camera.settings.input_triggers.frame_start.enable = True
p.video[0].camera.settings.input_triggers.frame_start.line = 0
p.video[0].camera.settings.input_triggers.frame_start.edge = TriggerEdge.Risingwas having no effect on configuration, so triggering was not actually enabled and the test was relying on the exposure time and compute for timing. Instead, I set the frame start trigger in its entirety with p.video[0].camera.settings.input_triggers.frame_start = Trigger(enable=True, line=0, edge='Rising')as in other Python tests. |
aliddell
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is already available in the C API. This PR simply exposes it in the Python API and adds a basic test with a simulated camera to exercise it.