Add spinnaker to drivers #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
reviewed
Oct 2, 2023
Comment on lines
+1
to
+2
| cmake_minimum_required(VERSION 3.5) | ||
| project(acquire-libs) |
src/storage.rs
Outdated
There was a problem hiding this comment.
Anything in here to look at besides formatting?
There was a problem hiding this comment.
No, this is just local auto-formatting from Nathan's commit.
tests/test_spinnaker.py
Outdated
| _runtime.set_configuration(acquire.Properties()) | ||
|
|
||
|
|
||
| def test_blackfly_camera_is_preset(runtime: acquire.Runtime): |
There was a problem hiding this comment.
This is copy-pasted from test_egrabber.py, but I think this should be present instead of preset, so I changed it in both places.
andy-sweet
commented
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds v0.1.1 of the spinnaker acquire driver to the drivers list used to build the Python package. It also adds some very basic Python tests to check that the devices are available.