Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build x86_64 and aarch64 wheels separately #79

Closed
wants to merge 18 commits into from

Conversation

aliddell
Copy link
Member

@aliddell aliddell commented Sep 1, 2023

Building wheels for separate architectures seems to work.

Changes

  • Build wheels for x86_64 and aarch64 on macOS.

@aliddell aliddell marked this pull request as ready for review September 5, 2023 14:47
@aliddell aliddell temporarily deployed to pypi September 5, 2023 16:57 — with GitHub Actions Inactive
@nclack
Copy link
Member

nclack commented Oct 3, 2023

@aliddell fwiw I "partially" merged main and things seemed to work on my mac. I'm wondering if we need this pr to merge, or if it's sufficient to go with the approach on main?

By "partially", I mean that I merged but didn't resolve the conflict, which doesn't affect my local build.

@aliddell
Copy link
Member Author

aliddell commented Oct 4, 2023

@nclack let me test it again tomorrow and if it works we can close.

@nclack
Copy link
Member

nclack commented Nov 13, 2023

closing, feel free to reopen

@nclack nclack closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants