Add a context manager for AvailableData
#70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nclack
reviewed
Aug 16, 2023
src/runtime.rs
Outdated
| consumed_bytes as _, | ||
| ) | ||
| .ok() | ||
| .expect("Unexpected failure: Was the CoreRuntime NULL?"); |
There was a problem hiding this comment.
Suggested change
| .expect("Unexpected failure: Was the CoreRuntime NULL?"); | |
| .expect("Unexpected failure"); |
|
My main concern with making |
…. Move RawAvailableData drop behavior into AvailableData.__exit__.
|
Quickly tested this while trying to reproduce/debug the build issue and found an issue when using the napari plugin to generate 100 frames for 1 simulated camera. The issue is that I don't get a layer or see any frames. I also get the following warning message in napari. Seems to work OK on main. |
…lies-on-deletion-for-cleanup
aliddell
added a commit
that referenced
this pull request
Dec 13, 2023
closes #68 This is an alternative to #70. This is in draft until I feel more confident about the tests and the napari plugin. But I think it's close. --------- Co-authored-by: Alan Liddell <[email protected]> Co-authored-by: Alan Liddell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.