Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exports from acquire.pyi #173

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

nclack
Copy link
Member

@nclack nclack commented Mar 5, 2024

See #171

@tlambert03
Copy link
Contributor

tlambert03 commented Mar 5, 2024

unfortunately nope... but this would work

scratch that! this works 👍

@tlambert03
Copy link
Contributor

sorry for the false alarm :). do this one! :)

@nclack
Copy link
Member Author

nclack commented Mar 5, 2024

sorry for the false alarm :). do this one! :)

I was so excited to see a pr from you!

And not quite a false alarm, we do have a test gap here. Opened an issue #174 to address that.

@nclack nclack requested a review from aliddell March 5, 2024 02:14
@tlambert03
Copy link
Contributor

Haha, and it turned out to be USELESS. I promise to follow up with something maybe slightly more useful as I play some more

Copy link
Member

@aliddell aliddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aliddell aliddell merged commit 21948cf into acquire-project:main Mar 8, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants