Handle null pointers returned from map_read()
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nclack
approved these changes
Jan 10, 2024
Comment on lines
+341
to
+345
| let nbytes = if beg.is_null() || end.is_null() { | ||
| 0 | ||
| } else { | ||
| unsafe { byte_offset_from(beg, end) } | ||
| }; |
There was a problem hiding this comment.
Fwiw, there's a rust feature that got stabilized in rust 1.75 that allows us to potentially replace bytes_offet_from with a method in the standard lib (see docs). Similarly for byte_offset.
Those methods don't look like they do any special null handling (playground) so you'd still need this null check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the error Micah ran into the other day.