-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capabilities interface #113
Merged
aliddell
merged 29 commits into
acquire-project:main
from
aliddell:zarrv3-plus-capabilities
Nov 28, 2023
Merged
Changes from 25 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
394f482
Update chunking API.
aliddell 0f40e26
Fix up README so Python code works as written and Spinnaker driver is…
aliddell 7ccb9c3
Add Zarr V3 tests. Add a note about environment variables in Zarr V3 …
aliddell 459aea8
Bump minor release version.
aliddell 8dbfa74
Update Zarr driver to v0.1.5.
aliddell 8fddb9f
Recall that target: pull_request is what you want when testing workfl…
aliddell e43b8eb
Update Zarr syntax in eGrabber tests.
aliddell 62ba589
Remove a bunch of commented code.
aliddell 11247d7
Expose AcquirePropertyMetadata as Capabilities (mypy and stubtest pas…
aliddell 317d52b
Tests for simulated camera capabilities.
aliddell 874bf9b
Merge remote-tracking branch 'upstream/main' into zarrv3-plus-capabil…
aliddell fefd5fc
Implement, but skip, testing storage metadata.
aliddell 6452f8b
Fix an image shape for simulated camera configuration to ensure consi…
aliddell dd26856
Restore test_pr to pull_request_target.
aliddell 79f117c
Unskip test_storage_capabilities.
aliddell 67b0205
Restore test_pr to pull_request_target (again).
aliddell 8cd2e2a
Test formatting.
aliddell e096742
Merge remote-tracking branch 'upstream/main' into zarrv3-plus-capabil…
aliddell 637e80f
Merge remote-tracking branch 'upstream/main' into zarrv3
aliddell 8d919d8
Update tests/test_basic.py
aliddell 72ae5e9
Update test_pr.yml
aliddell b3c90dd
Update Cargo.toml
aliddell 9b88453
Revert "Update Cargo.toml"
aliddell 22e1119
Merge branch 'zarrv3' into zarrv3-plus-capabilities
aliddell b0265bb
Merge remote-tracking branch 'upstream/main' into zarrv3-plus-capabil…
aliddell 63ebfae
Address PR comments.
aliddell 0920d5d
Ignore files created by `test_storage_capabilities`.
aliddell 1c102ee
Make Capabilities properties read-only.
aliddell 8fe4c0a
Split ChunkingShardingCapabilities into ChunkingCapabilities and Shar…
aliddell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't love the name of the type here because it's long and includes two needs (that are the same right now, but might diverge in the future?). Is it worth using the same underlying private definition, but defining separately named classes for
ChunkingCapabilities
andShardingCapabilities
?Similar comment for
ChunkingShardingDims
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I like the idea of exposing
ChunkingCapabilities
andShardingCapabilities
even though they derive from the same private type.