Add an append method that takes frame data, size, and shape #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated
Zarr::append()
to call the newZarr::append_frame()
. Multiscale logic goes fromappend()
intoappend_frame()
, so I needed to retoolZarr::write_multiscale_frames_()
to acceptuint8_t*
andsize_t
instead ofVideoFrame
.I also updated
Writer::write()
to both takeuint8_t*
andsize_t
instead ofVideoFrame
, and also return asize_t
of the number of bytes written in anticipation of establishing a contract around writing (separate PR). Because of this change, I had to update the unit tests around{Writer,ZarrV2Writer,ZarrV3Writer}::write()
, and I took the opportunity to define constant values instead of hardcoding numbers. The tests are otherwise the same.Also the unit tests are slightly reordered for aesthetic reasons.