Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an append method that takes frame data, size, and shape #279

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

aliddell
Copy link
Member

I updated Zarr::append() to call the new Zarr::append_frame(). Multiscale logic goes from append() into append_frame(), so I needed to retool Zarr::write_multiscale_frames_() to accept uint8_t* and size_t instead of VideoFrame.

I also updated Writer::write() to both take uint8_t* and size_t instead of VideoFrame, and also return a size_t of the number of bytes written in anticipation of establishing a contract around writing (separate PR). Because of this change, I had to update the unit tests around {Writer,ZarrV2Writer,ZarrV3Writer}::write(), and I took the opportunity to define constant values instead of hardcoding numbers. The tests are otherwise the same.

Also the unit tests are slightly reordered for aesthetic reasons.

@aliddell aliddell requested review from jeskesen and shlomnissan July 16, 2024 14:32
Copy link
Contributor

@jeskesen jeskesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@aliddell aliddell merged commit d4e3a34 into acquire-project:main Jul 17, 2024
3 checks passed
@aliddell aliddell deleted the write-contract branch July 17, 2024 13:49
@aliddell aliddell restored the write-contract branch July 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants