Support multiscale arrays in Zarr V3 with provisional metadata #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
requested review from
nclack,
jeskesen and
shlomnissan
and removed request for
nclack
…ale-arrays-in-zarr-v3-with-provisional-metadata
…ale-arrays-in-zarr-v3-with-provisional-metadata
jeskesen
approved these changes
Jul 23, 2024
src/zarr.cpp
Outdated
| { "type", "scale" }, | ||
| { "scale", scales }, | ||
| }, | ||
| } }, |
There was a problem hiding this comment.
trivial, but this indenting is confusing
src/zarr.cpp
Outdated
| { "type", "scale" }, | ||
| { "scale", scales }, | ||
| }, | ||
| } }, |
There was a problem hiding this comment.
trivial, but this indenting is confusing
aliddell
deleted the
250-support-multiscale-arrays-in-zarr-v3-with-provisional-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the same OME metadata as our Zarr V2 writer to express multiscale semantics. The following changes were made:
Zarr::make_multiscale_metadata_(), was implemented by moving the code fromZarrV2::write_group_metadata_()so that it could be made accessible to bothZarrV2andZarrV3instances.make_multiscale_metadata_()from both overrides ofwrite_group_metadata_().Zarr::get_meta()to reflect that both types of Zarr store support multiscale.Basic functionality is verified in the
write-zarr-v3-raw-multiscale.cpptest file. The test scheme is the same as inwrite-zarr-v2-raw-multiscale.cpp, but the paths are changed to reflect the different layout.