Breakout Zarr v2 files from #125 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
changed the title
andy-sweet
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Looks good to me. Most of my comments are minor additions or optional.
We've looked at this or similar a few times and I think there's enough understanding to get it in and move forward. There are still some parts of the code and execution order I don't have a good grasp on, but that can be improved in the future (both by me and by iterating on the code itself).
aliddell
force-pushed
the
zarrv3-part-one
branch
from
c434e74 to
352b2b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of #125.
Supersedes #113. Supersedes #117.
Closes #112. Closes #114. Closes #115.
Changes
Added
Changed
Fixed
append.