Skip to content

Commit

Permalink
removed unused version string from python api
Browse files Browse the repository at this point in the history
  • Loading branch information
jeskesen committed Jul 31, 2024
1 parent af1b336 commit e0b7827
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
5 changes: 0 additions & 5 deletions api/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ find_package(pybind11 REQUIRED)

pybind11_add_module(acquire_zarr acquire-zarr-py-api.cpp)

# EXAMPLE_VERSION_INFO is defined by setup.py and passed into the C++ code as a
# define (VERSION_INFO) here.
target_compile_definitions(acquire_zarr
PRIVATE VERSION_INFO=${EXAMPLE_VERSION_INFO})

target_include_directories(acquire_zarr PRIVATE ${acquire-zarr-cpp-api_SOURCE_DIR}/include)
target_link_libraries(acquire_zarr PRIVATE acquire-zarr-cpp)

Expand Down
8 changes: 1 addition & 7 deletions api/python/acquire-zarr-py-api.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
#include "acquire-zarr/acquire-zarr.hh"
#include <iostream>

#define STRINGIFY(x) #x
#define MACRO_STRINGIFY(x) STRINGIFY(x)
namespace py = pybind11;


Expand Down Expand Up @@ -73,9 +71,5 @@ PYBIND11_MODULE(acquire_zarr, m) {
.def_property("compression_level", &PyAcquireZarrWriter::get_compression_level, &PyAcquireZarrWriter::set_compression_level)
.def_property("compression_shuffle", &PyAcquireZarrWriter::get_compression_shuffle, &PyAcquireZarrWriter::set_compression_shuffle)
;
#ifdef VERSION_INFO
m.attr("__version__") = MACRO_STRINGIFY(VERSION_INFO);
#else
m.attr("__version__") = "dev";
#endif

}

0 comments on commit e0b7827

Please sign in to comment.