-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add vcpkg and remove hardcoded dependencies (#254)
**Summary** This PR adds vcpkg configurations for dependency management and removes hardcoded dependencies from the codebase. It also adds vcpkg to our GitHub Actions workflow and uses it to automatically install our dependencies. **Notes** - By integrating a package manager, we significantly simplify dependency management, improve our productivity, and promote consistency across environments. - In this configuration, there's no need to add vcpkg as a submodule to the project. Instead, individual users should install vcpkg in their home directory and set up the necessary environment variables (following this [guide](https://learn.microsoft.com/en-us/vcpkg/get_started/get-started?pivots=shell-bash).) - When we're ready to add [minio](https://vcpkg.io/en/package/minio-cpp), all we need to do is update `vcpkg.json` in the root folder. - I will update the README file with installation instructions and remove the hardcoded `json.hpp` library from the tests folder in separate PRs. **Test Plan** - All existing tests have passed. --------- Co-authored-by: Alan Liddell <[email protected]>
- Loading branch information
1 parent
9368165
commit 156b99e
Showing
25 changed files
with
111 additions
and
25,246 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"version": 3, | ||
"configurePresets": [ | ||
{ | ||
"name": "default", | ||
"binaryDir": "${sourceDir}/build", | ||
"cacheVariables": { | ||
"CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake" | ||
} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.