Apply suggestions from code review

Co-authored-by: Alan Liddell <[email protected]>
acquire-project · Oct 2, 2023 · f48a09c · f48a09c
1 parent 17eba82
commit f48a09c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -48,8 +48,8 @@ jobs:
 
       - name: Build
         run: |
-          cmake --build ${{github.workspace}}/pack --config Release
-          cpack --config ${{github.workspace}}/pack/CPackConfig.cmake -C Release -G ZIP
+          cmake --build ${{github.workspace}}/build--config Release
+          cpack --config ${{github.workspace}}/build/CPackConfig.cmake -C Release -G ZIP
 
       - uses: actions/upload-artifact@v3
         with:
@@ -80,8 +80,8 @@ jobs:
 
       - name: Build
         run: |
-          cmake --build ${{github.workspace}}/pack --config Release
-          cpack --config ${{github.workspace}}/pack/CPackConfig.cmake -C Release -G ZIP
+          cmake --build ${{github.workspace}}/build --config Release
+          cpack --config ${{github.workspace}}/build/CPackConfig.cmake -C Release -G ZIP
 
       - uses: actions/upload-artifact@v3
         with:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -100,10 +100,6 @@ jobs:
           cmake --build ${{github.workspace}}/build --config Release
           cpack --config ${{github.workspace}}/build/CPackConfig.cmake -C Release -G ZIP
 
-      - name: Test  # don't release unless tests pass
-        working-directory: ${{github.workspace}}/build
-        run: ctest -C Release -L anyplatform --output-on-failure
-
       - uses: actions/upload-artifact@v3
         with:
           name: ubuntu-latest Release binaries
@@ -134,10 +130,6 @@ jobs:
           cmake --build ${{github.workspace}}/build --config Release
           cpack --config ${{github.workspace}}/build/CPackConfig.cmake -C Release -G ZIP
 
-      - name: Test  # don't release unless tests pass
-        working-directory: ${{github.workspace}}/build
-        run: ctest -C Release -L anyplatform --output-on-failure
-
       - uses: actions/upload-artifact@v3
         with:
           name: macos-latest Release binaries