Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Add a PR template #37

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Add a PR template #37

merged 2 commits into from
Oct 25, 2023

Conversation

aliddell
Copy link
Member

Suggestions welcome. Should go in all the repos once it's approved.

@aliddell aliddell requested review from nclack and andy-sweet October 13, 2023 15:09
Copy link
Contributor

@andy-sweet andy-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in standup, this is good start, definitely better than the nothing we have now, and we can iteratively improve this as needed.

I made a few comments, some of which might be worth addressing, but none of which are blocking.

@aliddell
Copy link
Member Author

On closer consideration, you @andy-sweet and @nclack were right that putting changes here in changelog format are absolutely duplication of effort. If the submitter has checked all the boxes, the reviewer should be able to tell from looking at the changelog, if nothing else, what's changed, and in that exact format.

@aliddell aliddell merged commit fb5e06f into acquire-project:main Oct 25, 2023
3 checks passed
@aliddell aliddell deleted the pr-template branch October 25, 2023 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants