Remove 30-second timeout from thread_join. (#28)

acquire-project · Aug 28, 2023 · edb33ca · edb33ca
1 parent f56ba33
commit edb33ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Removes 30-second timeout from `thread_join` on Windows. 
+
 ### Added
 
 - `acquire-device-properties`: A `uint8_t` member `enable_multiscale` of `StorageProperties`.

diff --git a/src/acquire-core-platform/win32/platform.c b/src/acquire-core-platform/win32/platform.c
@@ -439,7 +439,7 @@ thread_join(struct thread* self)
         self->inner_ = INVALID_HANDLE_VALUE;
         TRACE("WFSO %p", thread);
         WaitForSingleObject(thread,
-                            30000); // FIXME: (nclack) set this back to INFINITE
+                            INFINITE);
         CloseHandle(thread);
     }
 }