Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Commit

Permalink
Remove git versioning (unused) (#31)
Browse files Browse the repository at this point in the history
In an effort to get rid of warnings like: "GIT_TAG and GIT_HASH
redefined", I'm going through and fixing up git-versioning.cmake
scripts.

Here though, none of the targets build by core libs use GIT_TAG or
GIT_HASH so I'm removing the script.
  • Loading branch information
nclack authored Sep 15, 2023
1 parent f634f76 commit a82da24
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 34 deletions.
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ cmake_policy(SET CMP0079 NEW) # use targets from other directories
enable_testing()

include(cmake/aq_require.cmake)
include(cmake/git-versioning.cmake)
include(cmake/ide.cmake)
include(cmake/msvc.cmake)

Expand Down
30 changes: 0 additions & 30 deletions cmake/git-versioning.cmake

This file was deleted.

1 change: 1 addition & 0 deletions src/acquire-core-logger/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
set(tgt acquire-core-logger)
add_library(${tgt} STATIC logger.h logger.c)
target_include_directories(${tgt} PUBLIC "${CMAKE_CURRENT_LIST_DIR}")

install(TARGETS ${tgt})
2 changes: 1 addition & 1 deletion src/acquire-core-platform/linux/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ add_library(${tgt} STATIC
platform.h
platform.c)
target_include_directories(${tgt} PUBLIC "${CMAKE_CURRENT_LIST_DIR}")
target_link_libraries(${tgt} PRIVATE Threads::Threads acquire-core-logger)
target_link_libraries(${tgt} PRIVATE Threads::Threads acquire-core-logger)
2 changes: 1 addition & 1 deletion src/acquire-core-platform/osx/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ add_library(${tgt} STATIC
platform.h
platform.c)
target_include_directories(${tgt} PUBLIC "${CMAKE_CURRENT_LIST_DIR}")
target_link_libraries(${tgt} PRIVATE acquire-core-logger)
target_link_libraries(${tgt} PRIVATE acquire-core-logger)
2 changes: 1 addition & 1 deletion src/acquire-core-platform/win32/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ add_library(${tgt} STATIC
platform.h
platform.c)
target_link_libraries(${tgt} PUBLIC acquire-core-logger)
target_include_directories(${tgt} PUBLIC "${CMAKE_CURRENT_LIST_DIR}")
target_include_directories(${tgt} PUBLIC "${CMAKE_CURRENT_LIST_DIR}")

0 comments on commit a82da24

Please sign in to comment.