-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align channel_write_map
requests to 8 bytes
#45
Merged
aliddell
merged 10 commits into
acquire-project:main
from
aliddell:misaligned-pointer-dereference
May 31, 2024
Merged
Align channel_write_map
requests to 8 bytes
#45
aliddell
merged 10 commits into
acquire-project:main
from
aliddell:misaligned-pointer-dereference
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
force-pushed
the
misaligned-pointer-dereference
branch
from
May 7, 2024 13:41
336c297
to
fe28e5c
Compare
aliddell
changed the title
Align VideoFrames to 8 bytes
Align May 7, 2024
channel_write_map
requests to 8 bytes
Co-authored-by: Nathan Clack <[email protected]>
nclack
reviewed
May 29, 2024
Co-authored-by: Nathan Clack <[email protected]>
nclack
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
aliddell
added a commit
that referenced
this pull request
Jun 4, 2024
* Define bytes_of_image() in components.h. * Catch errors thrown in one-video-stream.cpp. * Align VideoFrame struct to 64 bytes. * wip * Align to 8s when allocating VideoFrame. * fix line endings in components.h * Align to 8 when filtering as well. * Apply suggestions from code review Co-authored-by: Nathan Clack <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Clack <[email protected]> * Add a semicolon. --------- Co-authored-by: Nathan Clack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytes_of_image
to public API (components.h) and removes duplicate implementations in various .c files.channel_write_map
to 8 bytes.one-video-stream
test.