Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align channel_write_map requests to 8 bytes #45

Merged
merged 10 commits into from
May 31, 2024

Conversation

aliddell
Copy link
Member

@aliddell aliddell commented May 3, 2024

  • Adds bytes_of_image to public API (components.h) and removes duplicate implementations in various .c files.
  • Aligns all requests to channel_write_map to 8 bytes.
  • Catch exceptions in one-video-stream test.

@aliddell aliddell changed the title Align VideoFrames to 64 bytes Align VideoFrames to 16 bytes May 6, 2024
@aliddell aliddell force-pushed the misaligned-pointer-dereference branch from 336c297 to fe28e5c Compare May 7, 2024 13:41
@aliddell aliddell changed the title Align VideoFrames to 16 bytes Align VideoFrames to 8bytes May 7, 2024
@aliddell aliddell changed the title Align VideoFrames to 8bytes Align VideoFrames to 8 bytes May 7, 2024
@aliddell aliddell changed the title Align VideoFrames to 8 bytes Align channel_write_map requests to 8 bytes May 7, 2024
@aliddell aliddell marked this pull request as ready for review May 21, 2024 01:24
@aliddell aliddell requested review from nclack and jeskesen May 21, 2024 01:24
@aliddell aliddell requested a review from nclack May 29, 2024 19:11
Copy link
Member

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@aliddell aliddell merged commit 7afe044 into acquire-project:main May 31, 2024
9 checks passed
@aliddell aliddell deleted the misaligned-pointer-dereference branch May 31, 2024 14:40
aliddell added a commit that referenced this pull request Jun 4, 2024
* Define bytes_of_image() in components.h.

* Catch errors thrown in one-video-stream.cpp.

* Align VideoFrame struct to 64 bytes.

* wip

* Align to 8s when allocating VideoFrame.

* fix line endings in components.h

* Align to 8 when filtering as well.

* Apply suggestions from code review

Co-authored-by: Nathan Clack <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Clack <[email protected]>

* Add a semicolon.

---------

Co-authored-by: Nathan Clack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants