Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush the monitor's read region on stop if and only if it has already been initialized #43

Closed

Conversation

aliddell
Copy link
Member

In acquisitions where we call

runtime.start()
runtime.stop()

without inspecting the data at any point in between, the read-region flush on acquire_stop initializes the monitor. Calling this multiple times fills the monitor without ever flushing it, causing the runtime to hang. This fixes that problem.

@aliddell aliddell requested a review from nclack April 23, 2024 17:34
@aliddell
Copy link
Member Author

Confirm that the test in the new file repeat-start-no-monitor.cpp will hang without the change made in acquire.c.

@aliddell
Copy link
Member Author

Closed in favor of #44

@aliddell aliddell restored the dont-initialize-reader-on-stop branch April 24, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant