Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changes to the Storage identifier to propagate. #35

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Allow changes to the Storage identifier to propagate. #35

merged 2 commits into from
Jan 18, 2024

Conversation

aliddell
Copy link
Member

  • Fixes a bug where changing device identifiers for the storage device was not being handled correctly.

@aliddell aliddell requested a review from nclack January 17, 2024 22:06
nclack
nclack approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! one small suggestion on the test

acquire-driver-common/tests/integration/switch-storage-identifier.cpp Outdated Show resolved Hide resolved
@aliddell aliddell merged commit 1e9f286 into acquire-project:main Jan 18, 2024
8 checks passed
@aliddell aliddell deleted the switch-storage-devices branch January 18, 2024 13:37
@aliddell aliddell added the bug Something isn't working label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nclack nclack nclack approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Image Acquisition Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliddell @nclack