Move reserve_image_shape from acquire_start to acquire_configure
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
changed the title
reserve_image_shape from acquire-start to acquire-configurereserve_image_shape from acquire_start to acquire_configure
|
Is |
It is if you don't want the image shape to be part of the storage configuration, or for there to be a lag on the first append. The Zarr driver at least needs to know what the image shape is in order to allocate chunk buffers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
reserve_image_shapeinacquire_startwas an annoying workaround from when the Storage object was created during start and destroyed on stop. But now that storage is created at the latest during configure, we can reserve image shape earlier in the process.