Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get acquire-common building #1

Merged
merged 17 commits into from
Dec 22, 2023
Merged

Conversation

aliddell
Copy link
Member

@aliddell aliddell commented Dec 18, 2023

Includes all commits from acquire-core-libs, acquire-video-runtime, and acquire-driver-common.

  • Removed the PR template. It was a mistake.
  • Added @file docstring directive and brief description to all tests.
  • Moved write-side-by-side-tiff.cpp to tests under acquire-driver-common (previously under acquire-video-runtime).
  • Did a little additional validation in change-external-metadata.cpp.
  • The base CMakeLists.txt files for each of the subprojects were all simplified, since there's a new base project where all that can be handled.
  • CPack builds one big distributable, but it includes all the static libraries, headers, and the acquire-driver-common DLL.
    • Note that git versioning no longer works the way it used to, because we don't have separate git histories or tags for subdirectories, i.e., acquire-core-libs, acquire-video-runtime, and acquire-driver-common will all have the same versions from now on. I propose we go to 0.2.0 to reflect this change.

@aliddell aliddell marked this pull request as ready for review December 20, 2023 18:35
Copy link
Contributor

@andy-sweet andy-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great. Approving because CI is passing and I was able to build, test, and install successfully.

Most of my comments are small suggestions or questions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@aliddell aliddell merged commit 01a8b22 into acquire-project:main Dec 22, 2023
9 checks passed
@aliddell aliddell deleted the get-it-working branch December 22, 2023 14:41
@aliddell aliddell restored the get-it-working branch December 22, 2023 14:41
@aliddell aliddell deleted the get-it-working branch December 22, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants