Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAUT-11373 Use 'monolog.logger.mautic' instead of 'logger' #355

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

rohitp19
Copy link
Contributor

@rohitp19 rohitp19 commented Jul 1, 2024

Q A
Bug fix? (use the a.b branch) [Y]
New feature/enhancement? (use the a.x branch) [N]
Deprecations? [N]
BC breaks? (use the c.x branch) [N]
Automated tests included? [N]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes https://acquia.atlassian.net/browse/MAUT-11373

Description:

All the log should get written to console log instead of file.
'monolog.logger.mautic' use Symfony\Bridge\Monolog\Handler\ConsoleHandler handler
and ‘logger' is with Monolog\Handler\RotatingFileHandler handler which causes error when ‘logger’ is injected and try to write the log file on cloud.

Steps to test this PR:

  1. Open this PR for testing locally (see docs on testing PRs here)
    2.No QE test is required.

@avikarshasaha avikarshasaha self-requested a review July 3, 2024 05:26
@avikarshasaha avikarshasaha removed the request for review from fedys July 3, 2024 05:58
@rohitp19 rohitp19 merged commit 61d2b9f into staging Jul 12, 2024
3 checks passed
@rohitp19 rohitp19 deleted the MAUT-11373 branch July 12, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants