Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAUT-11467 : fix date issue if empty/not empty filter is used in segment filter #349

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

dadarya0
Copy link
Contributor

@dadarya0 dadarya0 commented Jun 4, 2024

Q A
Bug fix? (use the a.b branch) Yes
New feature/enhancement? (use the a.x branch) No
Deprecations? [ ]
BC breaks? (use the c.x branch) No
Automated tests included? Yes
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed https://acquia.atlassian.net/browse/MAUT-11467

Description:

Segment with custom object filter not working field type is date and operator is empty in filter

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create a custom object
  3. Add date type field in custom object
  4. Create segment
  5. Add filter with empty operator on CO field created in step - 2
  6. Rebuild segment
  7. Should not throw mysql query error

Other areas of Mautic that may be affected by the change:

List deprecations along with the new alternative:

List of areas covered by the unit and/or functional tests:

@dadarya0 dadarya0 requested review from a team, escopecz and rohitp19 and removed request for a team June 4, 2024 12:07
Copy link
Contributor

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue. Thanks!

@rohitp19 feel free to start with the second review.

@dadarya0 dadarya0 merged commit 946a115 into staging Jun 12, 2024
3 checks passed
@dadarya0 dadarya0 deleted the MAUT-11467 branch June 12, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants