-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAUT-11289 : Segments: New (not)between date filter #347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @dadarya0
# Conflicts: # Helper/QueryFilterHelper.php
Co-authored-by: Aarohi Prasad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on beta, working as expected. Thanks @dadarya0
@aarohiprasad @avikarshasaha conflict resolve please review PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dadarya0
@aarohiprasad @avikarshasaha please reapprove again, I have resolved conflict only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dadarya0
Description:
This PR adds new between and not between operators for the date fields and allows users to set 2 absolute dates like this:
The validation is also in place. This is how it looks like when one of the date ranges is empty:
Steps to test this PR: