Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GH Actions config #307

Merged
merged 53 commits into from
May 30, 2024
Merged

Adding GH Actions config #307

merged 53 commits into from
May 30, 2024

Conversation

escopecz
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Steps to test this PR:

  1. Open this PR for testing locally (see docs on testing PRs here)

@escopecz
Copy link
Contributor Author

escopecz commented Apr 23, 2024

@aadarshjain-dev any idea why is PHPSTAN reporting issues in file

 ------ ----------------------------------------------------------------------- 
  Line   DataPersister/CustomItemDataPersister.php                              
 ------ ----------------------------------------------------------------------- 
  9      Class                                                                  
         MauticPlugin\CustomObjectsBundle\DataPersister\CustomItemDataPersiste  
         r implements unknown interface                                         
         ApiPlatform\Core\DataPersister\DataPersisterInterface.                 
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols     
 ------ ----------------------------------------------------------------------- 

that doesn't exist in this branch but exists in the staging branch? I don't see how it would be possible with my limited knowledge of Github Action config files.

EDIT: It looks like it's the default behavior and there are good reasons for it: https://github.com/actions/checkout?tab=readme-ov-file#checkout-pull-request-head-commit-instead-of-merge-commit

@aadarshjain-dev
Copy link
Contributor

@aadarshjain-dev any idea why is PHPSTAN reporting issues in file

 ------ ----------------------------------------------------------------------- 
  Line   DataPersister/CustomItemDataPersister.php                              
 ------ ----------------------------------------------------------------------- 
  9      Class                                                                  
         MauticPlugin\CustomObjectsBundle\DataPersister\CustomItemDataPersiste  
         r implements unknown interface                                         
         ApiPlatform\Core\DataPersister\DataPersisterInterface.                 
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols     
 ------ ----------------------------------------------------------------------- 

that doesn't exist in this branch but exists in the staging branch? I don't see how it would be possible with my limited knowledge of Github Action config files.

EDIT: It looks like it's the default behavior and there are good reasons for it: https://github.com/actions/checkout?tab=readme-ov-file#checkout-pull-request-head-commit-instead-of-merge-commit

@escopecz so is this particular issue resolved/addressed by you?

@escopecz
Copy link
Contributor Author

Yes, it's resolved. Thanks for asking. I'm trying to make PHPSTAN and PHPUNIT work before we merge this.

@aadarshjain-dev
Copy link
Contributor

Yes, it's resolved. Thanks for asking. I'm trying to make PHPSTAN and PHPUNIT work before we merge this.

Great!!
Also when PHPSTAN and PHPUNIT are fixed, we can remove the commented steps to make the file clean (if not being used further)

@escopecz
Copy link
Contributor Author

Will do!

@fedys fedys self-requested a review May 30, 2024 11:46
@fedys fedys requested a review from rahuld-dev May 30, 2024 11:47
@fedys fedys merged commit 39584cb into staging May 30, 2024
3 checks passed
@fedys fedys deleted the gh-actions branch May 30, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants