-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
48 times of event do not display correct times #99
48 times of event do not display correct times #99
Conversation
…ot-display-correct-times
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback. Overall great PR! Very much was something in need of a fix so cheers all around for the research / implementation.
Comments mostly revolve overall on what imo is over-obscuring of functionality or not obscuring it in what I would argue is a healthy way for the developers first laying eyes on it w/ some explanations of my reasoning & external sources.
I agree and I can think of a better way to handle this later on. However, for now I believe we should stick with this unless there is a better idea. |
100%. Just was adding context to the PR 👍 |
Why
As of now, the time of an event does not reflect correctly due to issues with how the time is converted from the server.
What
Satisifes
Fixes https://linear.app/acmutsa/issue/HK-122/times-of-event-do-not-display-correct-times
#48
NOTE
There were concerns on the approach to solve this issue as the page that uses the timezone headers will run on the edge. By definition and our knowledge, this should mean that it would not work in a production environment. However, upon doing a bit more research, it seems that these headers were made for the edge network. The developer with concerns has been assigned to approve this PR.
Resources are linked here:
X-Vercel-ip-timezone
Vercel Discussion where request seems to stem from