-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactors user schema #77
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d37ffee
to
9eeafa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the small messages I left, but this is outstanding work. Thanks so much for this :)
Also, have you tested any sort of registering or queries on the db that you were given? Would like to know at least a few things were tried after the changes were made before we test on our db. |
@christianhelp It's been a little while, but iirc I was able to register under the new schema, and I didn't encounter any broken endpoints during manual testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Budget approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
513196a
Description:
Reorganizes and renames user data tables into a more extensible format for future feature additions.
Closes #76
Reviewers:
Review Guide:
Changelog:
Renames:
Moved Columns:
profileData -> userCommonData
userHackerData -> userCommonData
userCommonData -> userHackerData
Other: