Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vercel Build Issues #64

Merged
merged 7 commits into from
Jul 20, 2024
Merged

Fix Vercel Build Issues #64

merged 7 commits into from
Jul 20, 2024

Conversation

Lermatroid
Copy link
Member

@Lermatroid Lermatroid commented Jul 20, 2024 •
edited
Loading

Implements the following fixes:

  • Upgrade most packages
  • Major turbo upgrade, includes global env
  • Major env type checking
  • TSconfig updates, targeting ESNext
  • Removes prettier GH check on json files, as many are auto generated and are sparse in the project

Overall brings memory usage during build down from 6gb+ to ~ 500mb.

Fixes https://linear.app/acmutsa/issue/HK-133/fix-vercel-build-issues

@vercel Vercel
Copy link

vercel bot commented Jul 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-kit-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 3:36am

@Lermatroid
Copy link
Member Author

image

@Lermatroid Lermatroid marked this pull request as ready for review July 20, 2024 03:36
@Lermatroid Lermatroid requested a review from christianhelp July 20, 2024 03:36
christianhelp
christianhelp approved these changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@christianhelp christianhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for helping out with the build times :)

@linear Linear
Copy link

linear bot commented Jul 20, 2024

HK-133 Fix Vercel Build Issues

@Lermatroid Lermatroid merged commit 431030c into dev Jul 20, 2024
3 checks passed
@Lermatroid Lermatroid deleted the chore/fix-vercel-build-issues branch July 20, 2024 04:55
@Lermatroid Lermatroid self-assigned this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianhelp christianhelp christianhelp approved these changes

Assignees

@Lermatroid Lermatroid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lermatroid @christianhelp