Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

110 user table table pagination not functioning #150

Merged
merged 9 commits into from
Dec 25, 2024
Merged

110 user table table pagination not functioning #150

merged 9 commits into from
Dec 25, 2024

Conversation

meisullum
Copy link
Collaborator

@meisullum meisullum commented Dec 25, 2024 •
edited by christianhelp
Loading

Why

  • The UI had the opportunity to be touched up to make it more user-friendly
  • The original approach to rendering through search params and paginating was not functioning properly

What

  • Added a fuzzy search to the overall table
  • Allowed for sorting asc / desc in certain columns as well as filtering by columns
  • Made the UI more clear for certain columns
  • Compressed the view button into a clickable action

Satisfies

#110
https://linear.app/acmutsa/issue/HK-162/user-table-table-pagination-not-functioning

@meisullum meisullum linked an issue Dec 25, 2024 that may be closed by this pull request
User table table pagination not functioning #110
Closed
@vercel Vercel
Copy link

vercel bot commented Dec 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-kit-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 7:06am

christianhelp
christianhelp approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@christianhelp christianhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the work!

@christianhelp christianhelp merged commit f12863a into dev Dec 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianhelp christianhelp christianhelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User table table pagination not functioning
2 participants
@meisullum @christianhelp