Handle Empty Strings as Undefined in Environment Validation #147
+3,993
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiderCSman
requested review from
Lermatroid,
christianhelp and
jacobellerbrock
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@Lermatroid Ignoring the package-lock.json issue, is this what you are expecting from this issue? Just want to make sure that this is what is the purpose of #72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a helper function to treat empty strings as undefined during environment variable validation. The changes aim to simplify validation logic by avoiding repetitive .min(1) calls and ensuring empty strings are correctly flagged as invalid.
Changes Made:
Added stringOrUndefined Helper:
Ensures empty strings are treated as undefined.
Applies validation using .refine() and transformation using .transform().
Updated Server and Client Environment Variables:
Replaced z.string().min(1) with stringOrUndefined for consistency and maintainability.