Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hackathon Check-In Scanner #130

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Fix Hackathon Check-In Scanner #130

merged 6 commits into from
Oct 24, 2024

Conversation

christianhelp
Copy link
Collaborator

Why

The logic for the hackathon check-in scanner was claiming that users were not RSVP'd when they, in fact, were. Furthermore, the code for the scanner was messy and hard to follow with sometimes nested ternary rendering logic.

What

  • Rewrote the logic for the scanner to use the props passed in from the server component as the single source of truth
  • Used the useAction hook for taking care of handling success and error state
  • Further leveraged the toasts for giving loading, success, and error states
  • Added check to ensure users do not screenshot or use someone else's QR code by implementing both a client and server-side check to ensure no QR code is older than 5 minutes
  • Refactored the QR scanner code to be much cleaner to read and removed ternary rendering logic.
  • Rename the admin tab from "check-in" to "hackathon check-in"
  • Other small quality-of-life features

Satisfies

HK-174 (#127 )

@christianhelp christianhelp linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-kit-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 5:48am

@christianhelp christianhelp merged commit 638fd57 into dev Oct 24, 2024
3 checks passed
christianhelp added a commit to acmutsa/RowdyHacksX that referenced this pull request Oct 26, 2024
* migrate from clerk user metadata

* adds hackkit credits

* Added text saying only accepted files are PDF. Might want to make it dynamic later (acmutsa#121)

* Upgrade Next Safe Action (acmutsa#118)

* fix registration default

* Added "Presented by SWIVEL"

* Update README.md

* Fixed text overflow on user dashboard (#25)

* Fixed text sizing in user dashboard

* Formatted Project with Prettier

* Revert "Fixed text overflow on user dashboard (#25)" (#26)

This reverts commit ae09168.

* fixes overflow

* adds guilds

* fixes schedule default

* Add event location (acmutsa#124)

* add event location

* Prettier format

* fixed xs screen size overriding all other sizes (#28)

* updates bot name

* updates user profile

* updates media query size

* Adding Team Section (#29)

* meet the team page

* color change to show cards

* adjustments to card flip and mobile

* Testing on build if rotating cards is laggy

* Created team.json according to form/pictures as of 10/17

* Added all pictures

* RowdyHacks X Team Section added

* Prettier write

* Updated organizer list as of 10/21
Improved responsive design

* Added pictures for organizer list as of 10/21

* Prettier write

* Prettier write

* Updated pictures

* Prettier write

---------

Co-authored-by: Carter LaVigne <[email protected]>

* Merging in new schedule enhancements (acmutsa#128)

* schedule timeline initial styling

* Timeline days added

* add live pulsing effect

* add little line

* Bigger day headers

* run prettier

---------

Co-authored-by: joshuasilva414 <[email protected]>

* updates from prod

* Fix Hackathon Check-In Scanner (acmutsa#130)

* fix admin link check

* Satisfies User Settings w/ New Schema (acmutsa#112)

* test update image

* mobile optimize pass

* I made cool schedule (#33)

* Schedule timeline
* Mobile optimizations
* Prettier formatted

* fix current event logic

* fix current event display

* adds survival guide

* small event layout change

* updates theming

* updates settings

* updates build command

* Added sponsors section to the website (#37)

* Improved hacker dashboard color palette and fixed font issues (#38)

---------

Co-authored-by: joshuasilva414 <[email protected]>
Co-authored-by: Jacob Ellerbrock <[email protected]>
Co-authored-by: Joshua Silva <[email protected]>
Co-authored-by: Jacob <[email protected]>
Co-authored-by: Liam Murray <[email protected]>
Co-authored-by: Matthew Anderson <[email protected]>
Co-authored-by: Carter LaVigne <[email protected]>
jacobellerbrock added a commit to acmutsa/RowdyHacksX that referenced this pull request Oct 26, 2024
* migrate from clerk user metadata

* adds hackkit credits

* Added text saying only accepted files are PDF. Might want to make it dynamic later (acmutsa#121)

* Upgrade Next Safe Action (acmutsa#118)

* fix registration default

* Added "Presented by SWIVEL"

* Update README.md

* Fixed text overflow on user dashboard (#25)

* Fixed text sizing in user dashboard

* Formatted Project with Prettier

* Revert "Fixed text overflow on user dashboard (#25)" (#26)

This reverts commit ae09168.

* fixes overflow

* adds guilds

* fixes schedule default

* Add event location (acmutsa#124)

* add event location

* Prettier format

* fixed xs screen size overriding all other sizes (#28)

* updates bot name

* updates user profile

* updates media query size

* Adding Team Section (#29)

* meet the team page

* color change to show cards

* adjustments to card flip and mobile

* Testing on build if rotating cards is laggy

* Created team.json according to form/pictures as of 10/17

* Added all pictures

* RowdyHacks X Team Section added

* Prettier write

* Updated organizer list as of 10/21
Improved responsive design

* Added pictures for organizer list as of 10/21

* Prettier write

* Prettier write

* Updated pictures

* Prettier write

---------

Co-authored-by: Carter LaVigne <[email protected]>

* Merging in new schedule enhancements (acmutsa#128)

* schedule timeline initial styling

* Timeline days added

* add live pulsing effect

* add little line

* Bigger day headers

* run prettier

---------

Co-authored-by: joshuasilva414 <[email protected]>

* updates from prod

* Fix Hackathon Check-In Scanner (acmutsa#130)

* fix admin link check

* Satisfies User Settings w/ New Schema (acmutsa#112)

* test update image

* mobile optimize pass

* I made cool schedule (#33)

* Schedule timeline
* Mobile optimizations
* Prettier formatted

* fix current event logic

* fix current event display

* adds survival guide

* small event layout change

* updates theming

* updates settings

* updates build command

* Added sponsors section to the website (#37)

* Improved hacker dashboard color palette and fixed font issues (#38)

* Adding /live to broadcast livestream (#40)

* Created live page

* Added /live page

* Added Stream to page

* Updated lockfile

* Briefly fixed errors

* Prettier write

---------

Co-authored-by: joshuasilva414 <[email protected]>
Co-authored-by: Christian Walker <[email protected]>
Co-authored-by: Joshua Silva <[email protected]>
Co-authored-by: Liam Murray <[email protected]>
Co-authored-by: Matthew Anderson <[email protected]>
Co-authored-by: Christian Walker <[email protected]>
Co-authored-by: Carter LaVigne <[email protected]>
snehab2 pushed a commit to WEHackUTD/WEHackV that referenced this pull request Nov 16, 2024
@christianhelp christianhelp deleted the 127-fix-qr-scanner branch November 26, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix QR Scanner
1 participant