add THEIA_WEBVIEW_EXTERNAL_ENDPOINT env + new ingress for that

acend · Sep 4, 2023 · 5a6e0e7 · 5a6e0e7
1 parent ef745f9
commit 5a6e0e7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/deploy/charts/webshell/Chart.yaml b/deploy/charts/webshell/Chart.yaml
@@ -2,5 +2,5 @@ apiVersion: v2
 name: webshell
 description: A Helm chart to deploy a webshell environment
 type: application
-version: 0.4.4
-appVersion: "0.4.4"
+version: 0.4.5
+appVersion: "0.4.5"
diff --git a/deploy/charts/webshell/templates/deployment.yaml b/deploy/charts/webshell/templates/deployment.yaml
@@ -47,7 +47,9 @@ spec:
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           env:
           - name: USER
-            value: "{{ .Values.user }}"
+            value: {{ .Values.user }}
+          - name: THEIA_WEBVIEW_EXTERNAL_ENDPOINT
+            value: {{ .Values.theia.webview_url }}
           ports:
             - name: web
               containerPort: 3000

diff --git a/deploy/charts/webshell/values.yaml b/deploy/charts/webshell/values.yaml
@@ -11,6 +11,7 @@ image:
   pullPolicy: IfNotPresent
 
 theia:
+  webview_url: "{{uuid}}.webview.{{hostname}}"
   image:
     repository: quay.io/acend/theia
     # Overrides the image tag whose default is the chart appVersion.