Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new AWS StorageClasses #287

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Implement new AWS StorageClasses #287

merged 2 commits into from
Oct 10, 2023

Conversation

cfahrni
Copy link
Contributor

@cfahrni cfahrni commented Oct 10, 2023

Available StorageClasses: gp2-csi, gp3-csi (default)

@cfahrni
Implement new AWS StorageClasses
f9138f4 
Available StorageClasses: gp2-csi, gp3-csi (default)
@bliemli
Copy link
Member

bliemli commented Oct 10, 2023

It might be easier to simply remove the storageClassName field completely. This way, we wouldn't have to update it every time AWS/OpenShift update the storage types/classes. What do you think?

@bliemli
Copy link
Member

bliemli commented Oct 10, 2023

Nice, thank you!

@cfahrni
Copy link
Contributor Author

cfahrni commented Oct 10, 2023

That makes sense to me and is more future proof. I've removed the storageClassName and verified it .

@bliemli bliemli merged commit 2af9d49 into acend:main Oct 10, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfahrni @bliemli