fix(apis_entities,apis_relations): drop login_url override #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1rger
force-pushed
the
birger/drop-login-view-override
branch
from
a7f0709
to
b1ae3d2
Compare
b1rger
force-pushed
the
birger/drop-login-view-override
branch
from
b1ae3d2
to
fc37050
Compare
The default login_url for the UserPassesTestMixin defaults to settings.LOGIN_URL which defaults to "/accounts/login/" - therefore the override does not make sense.
b1rger
force-pushed
the
birger/drop-login-view-override
branch
from
fc37050
to
e44ba2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default login_url for the UserPassesTestMixin defaults to
settings.LOGIN_URL which defaults to "/accounts/login/" - therefore the
override does not make sense.