Check default case

accumulator · Nov 22, 2022 · d9dc8c9 · d9dc8c9
1 parent 83caf18
commit d9dc8c9
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/charge_lnd/policy.py b/charge_lnd/policy.py
@@ -366,20 +366,18 @@ def match_by_chan(self, channel, config):
                     return False
 
             htlcs_total = fwds['htlc_in'] + fwds['htlc_out']
-            if htlcs_total > 0:
-                htlcs_ratio = fwds['htlc_in'] / htlcs_total
-                if 'chan.max_htlcs_ratio' in config and not config.getfloat('chan.max_htlcs_ratio') >= htlcs_ratio:
-                    return False
-                if 'chan.min_htlcs_ratio' in config and not config.getfloat('chan.min_htlcs_ratio') <= htlcs_ratio:
-                    return False
+            htlcs_ratio = fwds['htlc_in'] / htlcs_total if htlcs_total else float('nan')
+            if 'chan.max_htlcs_ratio' in config and not config.getfloat('chan.max_htlcs_ratio') >= htlcs_ratio:
+                return False
+            if 'chan.min_htlcs_ratio' in config and not config.getfloat('chan.min_htlcs_ratio') <= htlcs_ratio:
+                return False
 
             sats_total = fwds['sat_in'] + fwds['sat_out']
-            if sats_total > 0:
-                sats_ratio = fwds['sat_in'] / sats_total
-                if 'chan.max_sats_ratio' in config and not config.getfloat('chan.max_sats_ratio') >= sats_ratio:
-                    return False
-                if 'chan.min_sats_ratio' in config and not config.getfloat('chan.min_sats_ratio') <= sats_ratio:
-                    return False
+            sats_ratio = fwds['sat_in'] / sats_total if sats_total else float('nan')
+            if 'chan.max_sats_ratio' in config and not config.getfloat('chan.max_sats_ratio') >= sats_ratio:
+                return False
+            if 'chan.min_sats_ratio' in config and not config.getfloat('chan.min_sats_ratio') <= sats_ratio:
+                return False
 
         return True