Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts updated #41

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

Priyaccuknox
Copy link
Contributor

I have modified the charts according to the latest changes made in the main branch

@nyrahul
Copy link
Contributor

nyrahul commented Sep 19, 2024

Hey @Priyaccuknox , great to see this work ...
Can you avoid copying the manifests and use symbolic links or some other way such that we can either use a single chart or multiple charts (using current way)?
Looking forward to reviewing this.

@Priyaccuknox
Copy link
Contributor Author

Hey @Priyaccuknox , great to see this work ... Can you avoid copying the manifests and use symbolic links or some other way such that we can either use a single chart or multiple charts (using current way)? Looking forward to reviewing this.

Sure @nyrahul Let me look into this.

@nyrahul
Copy link
Contributor

nyrahul commented Sep 20, 2024

Hey @Priyaccuknox , you are raising the PR to a different branch! You need to raise a PR to main. Secondly, please do not duplicate manifests. You can discuss this internally, if no one is clear about this in devops then we can discuss. CC: @SujithKasireddy

@Priyaccuknox
Copy link
Contributor Author

Hey @Priyaccuknox , you are raising the PR to a different branch! You need to raise a PR to main. Secondly, please do not duplicate manifests. You can discuss this internally, if no one is clear about this in devops then we can discuss. CC: @SujithKasireddy

Yes @nyrahul , based on @raviknox request, I raised the PR to a separate branch for testing instead of merging directly into the main branch. I will discuss the duplicate manifest issue internally as well.

@Priyaccuknox Priyaccuknox merged commit d94f0da into accuknox:consol-charts Sep 23, 2024
3 checks passed
@Priyaccuknox
Copy link
Contributor Author

Hi @nyrahul,
I have updated the charts using symlinks as per the requirement in a separate branch consol-charts
Once we test and confirm everything is working fine, we can merge it into the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants