Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: learning pathway build implementation && intro tour guide #96

Merged
merged 27 commits into from
Sep 3, 2024
Merged

feat: learning pathway build implementation && intro tour guide #96

merged 27 commits into from
Sep 3, 2024

Conversation

Vinyl-Davyl
Copy link
Collaborator

@Vinyl-Davyl Vinyl-Davyl commented Aug 19, 2024 •
edited
Loading

Closes #51 #52 #53 #54

Summary

This pull request introduces a new learning pathway for the playground. It includes updated content and navigation for the learning experience. This feature is a progress update and would be further refined.

Changes

  • Added new learning steps and modules to the playground.
  • Implemented a sidebar for navigating through different learning pathways.
  • Updated the content fetching logic to dynamically load the learning modules.
  • Enhanced the UI to improve user experience and navigation.

Flags

  • The feature is currently in progress and may require further adjustments.
  • The contents in the content folder in the .md files are subjected to updates.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@Vinyl-Davyl Vinyl-Davyl requested a review from a team as a code owner August 19, 2024 16:23
@netlify Netlify
Copy link

netlify bot commented Aug 19, 2024 •
edited
Loading

✅ Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 2e3f24b
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/66d20b2d3c3e3400088be642
😎 Deploy Preview https://deploy-preview-96--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sanketshevkar
sanketshevkar requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@sanketshevkar sanketshevkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I see a few problems in the preview.
preview-window
Can we please highlight the whole component?
learn-now-not-found
I got 404 on the learn now page

@sanketshevkar
Copy link
Member

Can you please complete the DCO signoff as well?

@Vinyl-Davyl Vinyl-Davyl changed the title feat: created and introduced new learning pathway structure feat: implemented initial learning pathway build && intro tour guide Aug 22, 2024
@Vinyl-Davyl Vinyl-Davyl changed the title feat: implemented initial learning pathway build && intro tour guide feat: implemented learning pathway build && intro tour guide Aug 22, 2024
@Vinyl-Davyl Vinyl-Davyl changed the title feat: implemented learning pathway build && intro tour guide feat: learning pathway build implementation && intro tour guide Aug 22, 2024
@Vinyl-Davyl Vinyl-Davyl force-pushed the vinyl/feat/intro-tooltip branch 3 times, most recently from f41641b to 5321b22 Compare August 23, 2024 13:58
@Vinyl-Davyl Vinyl-Davyl force-pushed the vinyl/feat/intro-tooltip branch 3 times, most recently from 8aed094 to ba4fb1a Compare August 28, 2024 13:18
@sanketshevkar
Copy link
Member

The anchor tag here is still buggy.
When I click it, the learning pathway also renders back to the Editor. So I have two editors open now.
image

Why not open up the learning pathway in a separate tab from the Learn Now button itself. Atleast one of them should be functional.

@sanketshevkar
Copy link
Member

sanketshevkar commented Aug 30, 2024 •
edited
Loading

LGTM! I see a few problems in the preview. preview-window
And the problem with the first screenshot still exists.

nitro56565 and others added 13 commits August 30, 2024 18:47
@nitro56565 @Vinyl-Davyl
cursor inconsistency in editor fixed (accordproject#95)
19ee755 
Signed-off-by: Mahesh Patil <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update(ui): secondary theme color (accordproject#93)
cc5dfe6 
* update: development

Signed-off-by: Vinyl-Davyl <[email protected]>

* update: development

Signed-off-by: Vinyl-Davyl <[email protected]>

---------

Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
chore(doc): doc updated with recent project feature (accordproject#92)
0c5e033 
* update: development

Signed-off-by: Vinyl-Davyl <[email protected]>

* update: development

Signed-off-by: Vinyl-Davyl <[email protected]>

---------

Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
77a9b88 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
044aadb 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
5339875 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
b4b26ea 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
66efc30 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
b407722 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
c712d9c 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update development
d653999 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
dded3a1 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
3df01c4 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
Vinyl-Davyl and others added 13 commits August 30, 2024 18:47
@Vinyl-Davyl
update: development
19a5f41 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
61b47ab 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
d5d7602 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
71e3328 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
c11f4ef 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
029971d 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
92e1d1b 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
chore: updated contents
4aeb497 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
2ddf0e7 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
4beca0d 
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
3aa4d4b 
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
c2b14e8 
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl
update: development
23a3696 
Signed-off-by: Vinyl-Davyl <[email protected]>
@Vinyl-Davyl Vinyl-Davyl force-pushed the vinyl/feat/intro-tooltip branch from cc5b4c7 to 23a3696 Compare August 30, 2024 17:51
@Vinyl-Davyl
Copy link
Collaborator Author

The anchor tag here is still buggy. When I click it, the learning pathway also renders back to the Editor. So I have two editors open now. image

Why not open up the learning pathway in a separate tab from the Learn Now button itself. Atleast one of them should be functional.

Yeah, I totally get! Resolved now! Good to go.

sanketshevkar
sanketshevkar approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@sanketshevkar sanketshevkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sanketshevkar
Copy link
Member

Very happy with the progress made over the summer. Good job David!

@sanketshevkar sanketshevkar merged commit a39c4c6 into accordproject:main Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketshevkar sanketshevkar sanketshevkar approved these changes

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create reusable components such as helper text box, editors
3 participants
@Vinyl-Davyl @sanketshevkar @nitro56565