Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(GUI): white-spacing in monaco editor #74

Merged

Conversation

nitro56565
Copy link
Contributor

@nitro56565 nitro56565 commented Jun 20, 2024

Changes

  • Addressed an issue where the white-spacing in the Monaco editor was not consistent, it led to disturbance in layout of the template block.

Screenshots or Video

before_change
after_change

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@nitro56565 nitro56565 requested a review from a team as a code owner June 20, 2024 10:21
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 93e845c
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/667419b6cd50250008e9ffc8
😎 Deploy Preview https://deploy-preview-74--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nitro56565 nitro56565 force-pushed the nitro56565/i72/whitspace-in-editor branch from 786e61c to 1e5764b Compare June 20, 2024 10:29
@nitro56565 nitro56565 changed the title Fix(GUI): white-spacing in monaco editor #72 Fix(GUI): white-spacing in monaco editor Jun 20, 2024
Copy link
Member

@sanketshevkar sanketshevkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nitro56565 for your contributions.
Can you please fix the whitespaces and formatting that were newly added for this PR. There is new diff generated due to whitespaces and formatting. It'll help us to easily review the code that fixes the issue.

@nitro56565 nitro56565 force-pushed the nitro56565/i72/whitspace-in-editor branch from 69ea520 to 93e845c Compare June 20, 2024 11:59
@nitro56565
Copy link
Contributor Author

@sanketshevkar I have fixed the whitespaces and formatting
#74

@nitro56565 nitro56565 requested a review from sanketshevkar June 20, 2024 13:34
Copy link
Member

@sanketshevkar sanketshevkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @nitro56565 !!
Thanks for your contributions.

@sanketshevkar sanketshevkar merged commit 355364d into accordproject:main Jun 21, 2024
7 checks passed
Vinyl-Davyl pushed a commit to Vinyl-Davyl/template-playground that referenced this pull request Jun 22, 2024
* removed the whitespace in monaco editor

Signed-off-by: Mahesh Patil <[email protected]>

* Fixed whitspace and formatting

Signed-off-by: Mahesh Patil <[email protected]>

---------

Signed-off-by: Mahesh Patil <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
Vinyl-Davyl pushed a commit to Vinyl-Davyl/template-playground that referenced this pull request Jun 22, 2024
* removed the whitespace in monaco editor

Signed-off-by: Mahesh Patil <[email protected]>

* Fixed whitspace and formatting

Signed-off-by: Mahesh Patil <[email protected]>

---------

Signed-off-by: Mahesh Patil <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
@nitro56565 nitro56565 deleted the nitro56565/i72/whitspace-in-editor branch July 19, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants