Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Dark Mode Toggle Feature #112

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

nitro56565
Copy link
Contributor

@nitro56565 nitro56565 commented Nov 8, 2024

Feature - Dark Mode Toggle

Changes

  • Added a Dark Mode toggle feature to the Template Playground.
  • Implemented global states in the store to manage the dark mode theme for the entire page.
  • Integrated the dark mode functionality across various components using the global state.
  • Implemented the dark mode for Monaco editor dynamically as well
  • Updated the background and text colors dynamically based on the theme.

Flags

  • Ensure that the global state changes are properly synced across all components that need the theme update.

Screenshots or Video

Screenshot from 2024-11-08 19-23-50
Screenshot from 2024-11-08 19-23-58

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: nitro56565 <[email protected]>
@nitro56565 nitro56565 requested a review from a team as a code owner November 8, 2024 13:59
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit faa04bb
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/672e1e5d952f7a0008fc5098
😎 Deploy Preview https://deploy-preview-112--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you.

@dselman dselman merged commit e76ddd0 into accordproject:main Nov 9, 2024
7 checks passed
@nitro56565 nitro56565 deleted the nitro56565/dark-mode-toggle branch November 9, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants