Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lines count display option #136

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mcallegari
Copy link

At the moment works only with GIT
Enabled with --lines

@mcallegari
Copy link
Author

@acaudwell any particular reason for not merging this yet ?

@acaudwell
Copy link
Owner

I haven't had a good look at it yet.

@Damov
Copy link

Damov commented Dec 27, 2017

It's nice, I've tried it out. Good work!

@ghost
Copy link

ghost commented Jan 29, 2018

The "obviously wrong delta lines calculation" may not the correct solution either. Git counts added lines and removed lines in an odd way. Any change/edit to an existing line counts as 1 add and 1 remove. If you subtract you get 0. This is why most git based line-counts report adds and removes separately. If you just want to count changed lines its just "added" total. The removed - added may reflect actual removed code but I have found git is not always accurate with determining replace vs add so I prefer to just count "added" and not worry about "removed". I actually find the entire idea of line-counts useless and prefer commit counts ;)

@sinux-l5d
Copy link

Hi,
Is it still possible to implement this feature?
Or the limit described in #136 (comment) is still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants